Skip to content

♻️Maintenance: remove circular dependency #8245

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Aug 21, 2025
Merged

♻️Maintenance: remove circular dependency #8245

merged 3 commits into from
Aug 21, 2025

Conversation

@sanderegg
Copy link
Member

@sanderegg sanderegg commented Aug 21, 2025 •
edited
Loading

What do these changes do?

In order to make the simultaneous access using the new is-collaborative label work, this pre-requisiste is needed.
This should have no effect on the functionality.

This basically moves models from models-library/docker.py to services_metadata_runtime.py

Related issue/s

How to test

Dev-ops

@sanderegg sanderegg added this to the Voyager milestone Aug 21, 2025
@sanderegg sanderegg self-assigned this Aug 21, 2025
@sanderegg sanderegg added the a:webserver webserver's codebase. Assigning the area is particularly useful for bugs label Aug 21, 2025
@sanderegg sanderegg requested a review from pcrespov as a code owner August 21, 2025 14:56
@sanderegg sanderegg added the a:dynamic-sidecar dynamic-sidecar service label Aug 21, 2025
@codecov
Copy link

codecov bot commented Aug 21, 2025 •
edited
Loading

Codecov Report

❌ Patch coverage is 93.05556% with 5 lines in your changes missing coverage. Please review.
✅ Project coverage is 89.82%. Comparing base (81315d3) to head (1aba58b).
⚠️ Report is 14 commits behind head on master.

Additional details and impacted files 
@@            Coverage Diff             @@
##           master    #8245      +/-   ##
==========================================
+ Coverage   88.01%   89.82%   +1.81%     
==========================================
  Files        1916     1508     -408     
  Lines       74117    62257   -11860     
  Branches     1301      498     -803     
==========================================
- Hits        65232    55925    -9307     
+ Misses       8494     6203    -2291     
+ Partials      391      129     -262
Flag Coverage Δ
integrationtests 64.00% <100.00%> (+0.02%) ⬆️
unittests 88.21% <93.05%> (+1.55%) ⬆️
Components Coverage Δ
pkg_aws_library ∅ <ø> (∅)
pkg_celery_library ∅ <ø> (∅)
pkg_dask_task_models_library ∅ <ø> (∅)
pkg_models_library 93.04% <90.74%> (+<0.01%) ⬆️
pkg_notifications_library ∅ <ø> (∅)
pkg_postgres_database ∅ <ø> (∅)
pkg_service_integration 70.19% <ø> (ø)
pkg_service_library ∅ <ø> (∅)
pkg_settings_library ∅ <ø> (∅)
pkg_simcore_sdk 85.03% <ø> (ø)
agent 93.90% <ø> (ø)
api_server 92.84% <ø> (ø)
autoscaling 95.89% <100.00%> (+<0.01%) ⬆️
catalog 92.34% <ø> (ø)
clusters_keeper 99.13% <ø> (ø)
dask_sidecar 92.15% <ø> (ø)
datcore_adapter 97.94% <ø> (ø)
director 75.81% <ø> (-0.09%) ⬇️
director_v2 91.01% <100.00%> (+0.03%) ⬆️
dynamic_scheduler 96.27% <ø> (ø)
dynamic_sidecar 90.05% <ø> (ø)
efs_guardian 89.62% <ø> (ø)
invitations 91.44% <ø> (ø)
payments 92.61% <ø> (ø)
resource_usage_tracker 92.13% <ø> (-0.06%) ⬇️
storage 86.34% <ø> (-0.09%) ⬇️
webclient ∅ <ø> (∅)
webserver 88.08% <ø> (-0.01%) ⬇️

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 81315d3...1aba58b. Read the comment docs.

🚀 New features to boost your workflow:
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

matusdrobuliak66
matusdrobuliak66 approved these changes Aug 21, 2025
View reviewed changes
Copy link
Collaborator

@matusdrobuliak66 matusdrobuliak66 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks.

@sonarqubecloud
Copy link

sonarqubecloud bot commented Aug 21, 2025

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

@mergify
Copy link
Contributor

mergify bot commented Aug 21, 2025 •
edited
Loading

🧪 CI Insights

Here's what we observed from your CI run for 1aba58b.

✅ Passed Jobs With Interesting Signals

Pipeline Job Signal Health on base branch Retries 🔍 CI Insights 📄 Logs
CI unit-tests Base branch is broken, but the job passed. Looks like this might be a real fix 💪 Broken 0 View View

@sanderegg sanderegg merged commit c94ea58 into ITISFoundation:master Aug 21, 2025
95 checks passed
@sanderegg sanderegg deleted the maintenance/refactor-is-collaborative-metadata-location branch August 21, 2025 15:42
@sanderegg sanderegg added the t:maintenance Some planned maintenance work label Aug 26, 2025
@matusdrobuliak66 matusdrobuliak66 mentioned this pull request Sep 2, 2025
Closed
61 tasks
@matusdrobuliak66 matusdrobuliak66 mentioned this pull request Sep 18, 2025
Closed
17 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@matusdrobuliak66 matusdrobuliak66 matusdrobuliak66 approved these changes

@pcrespov pcrespov Awaiting requested review from pcrespov pcrespov is a code owner

@GitHK GitHK Awaiting requested review from GitHK GitHK is a code owner

@giancarloromeo giancarloromeo Awaiting requested review from giancarloromeo giancarloromeo is a code owner

Assignees

@sanderegg sanderegg

Labels

a:dynamic-sidecar dynamic-sidecar service a:models-library a:webserver webserver's codebase. Assigning the area is particularly useful for bugs t:maintenance Some planned maintenance work

Projects

None yet

Milestone

Voyager

Development

Successfully merging this pull request may close these issues.

2 participants

@sanderegg @matusdrobuliak66